Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move expectation out of let block #2558

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −5
Open

Move expectation out of let block #2558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dd4e78
Move expectation out of let block
ekohl Aug 16, 2024
16a0d0a
Add additional verifications to userdir testing
ekohl Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions spec/defines/vhost_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2171,12 +2171,14 @@
'enabled bob',
],
)
end

it {
expect(subject).to contain_concat__fragment('rspec.example.com-apache-userdir')
.with(content: %r{^\s+UserDir disabled$})
.with(content: %r{^\s+UUserDir enabled bob$})
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there was already a typo in UUserDir here, which is proof the test didn't ran.

}
it { is_expected.to compile.with_all_deps }
it { is_expected.to contain_class('apache::mod::userdir') }
it do
expect(subject).to contain_concat__fragment('rspec.example.com-userdir')
.with(content: %r{^\s+UserDir disabled$})
.with(content: %r{^\s+UserDir enabled bob$})
end
end
end
Expand Down
Loading