BUGFIX: Decode string based on byteorder of system #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
patch already validated in openSUSE since a while: https://build.opensuse.org/package/view_file/openSUSE:Factory:PowerPC/python-datrie/datrie-bigendian.patch?expand=1 |
|
Yep, we'll probably use a similar patch for Fedora until the PR is accepted. |
|
I just added this to the Debian package, thanks all! |
sarnold
added a commit
to freepn/datrie
that referenced
this pull request
Nov 16, 2020
* respin debian patch * add endian fix from upstream PR Origin1: https://salsa.debian.org/python-team/packages/python-datrie/-/tree/master/debian/patches Origin2: upstream, pytries#85 Signed-off-by: Stephen L Arnold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
Big-endian machines are unable to decode the UTF-32 encoded strings. The default decoding is for little-endian machines. Therefore, added a simple if condition to identify the type of machine before decoding the string.