Show more records, records items per page #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #306 +/- ##
==========================================
- Coverage 37.76% 34.40% -3.36%
==========================================
Files 96 66 -30
Lines 3948 3784 -164
==========================================
- Hits 1491 1302 -189
- Misses 2457 2482 +25 ☔ View full report in Codecov by Sentry. |
dimasciput
reviewed
Nov 20, 2023
qgis-app/plugins/views.py
Outdated
| @@ -605,6 +605,8 @@ def get_context_data(self, **kwargs): | |||
| context.update(self.additional_context) | |||
| context["current_sort_query"] = self.get_sortstring() | |||
| context["current_querystring"] = self.get_querystring() | |||
| context["per_page_list"] = [20, 50, 75, 100] | |||
| context["show_more_items_number"] = context["paginator"].per_page + 50 | |||
There was a problem hiding this comment.
It should be based on the number from per_page_list
There was a problem hiding this comment.
Yes, you're right. I have fixed it.
dimasciput
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please find below a GIF of the show more button and elements per page options: