Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid icon in plugins list and details #425

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Jun 6, 2024

This is the proposed fix for #421

Changes summary

  • Add a filter is_image_valid to check for invalid images to handle errors from solr thumbnail
  • Show the default QGIS icon (plugins list and detail) when a plugin's icon is invalid

image

@Xpirix Xpirix requested a review from dimasciput June 6, 2024 13:34
@dimasciput dimasciput merged commit 0635b62 into qgis:master Jun 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants