Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback clarification #452

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Feedback clarification #452

merged 6 commits into from
Aug 5, 2024

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Jul 31, 2024

Fix for #447

Changes summary

  • Added a new list for Reviewd plugins (Resolved comments)
  • Change Feedback received to Reviewed plugins (Awaiting comments resolution)
  • Change Feedback pending to Awaiting review
  • Fix plugins list for Unapproved, Reviewd plugins (Resolved comments), Reviewed plugins (Awaiting comments resolution), Awaiting review to match the workflow
  • Update unit test
plugins-review.mov

@Xpirix Xpirix requested a review from dimasciput July 31, 2024 12:31
dimasciput
dimasciput approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@dimasciput dimasciput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although the naming could be simplified, I think. But let's deploy this for now.

@Xpirix
Copy link
Collaborator Author

Xpirix commented Aug 5, 2024

Thanks for the review @dimasciput , how about the following texts?

image

@dimasciput
Copy link
Collaborator

@Xpirix I think that's better, thanks!

@Xpirix Xpirix merged commit 2318c6b into qgis:master Aug 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimasciput dimasciput dimasciput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xpirix @dimasciput