Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gps.h and use distro's version #662

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

waveform80
Copy link
Contributor

During the main-inclusion review process for the userland package in Ubuntu, we noticed that the camera binaries are attempting to dynamically load a version of libgps that doesn't exist in Ubuntu (.so.23 instead of .so.26).

This patch removes the copy of gps.h from the code, relying instead on the gps.h shipped with the distro (by libgps-dev which I've added as a build-dep for our release).

That much is simple enough, but the current version of libgps in Ubuntu has moved from using doubles (as timestamp_t) to timespec_t structures for greater accuracy. This patch also adds some trivial fixes for this change too.

For this reason, this patch shouldn't be merged for Raspbian Buster. If you want the gps.h removal in Raspbian Buster, I'm happy to split the patch into two, but I thought it might be better to simply leave this open until Raspbian Bullseye?

This patch removes the copy of gps.h from the code, relying instead on
the gps.h shipped with the distro (by libgps-dev).

That much is simple enough, but the current version of libgps has moved
from using doubles (as timestamp_t) to timespec_t structures for greater
accuracy. This patch also adds some trivial fixes for this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant