Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling #31

Merged
merged 60 commits into from
Jul 30, 2023
Merged

Spelling #31

merged 60 commits into from
Jul 30, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jul 27, 2023

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/realopinsight/actions/runs/5682494915#summary-15401001697

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/realopinsight/actions/runs/5682495132#summary-15401002264

jsoref
jsoref commented Jul 27, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
contribs/etc/wt_config.xml
@@ -207,7 +207,7 @@
<max-memory-request-size>1024</max-memory-request-size>
</connector-isapi>

<!-- Javascript debug options
<!-- JavaScript debug options
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brand (matches below...)

contribs/etc/wt_config.xml
@@ -336,7 +336,7 @@

<!-- Whether inline CSS is allowed.
Some Wt widgets will insert CSS rules in the the inline
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate words aren't technically misspellings, but spell-checking tools have flagged them for ages, so...

core/src/K8sHelper.cpp
return std::make_tuple(ngrt4n::K8sPending, "", QObject::tr("container is wating").toStdString());
return std::make_tuple(ngrt4n::K8sPending, "", QObject::tr("container is waiting").toStdString());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably breaks translations.

There is an fr translation. For simplicity, I opted to not touch that file, and am hoping your translation process will deal w/ the change, but I can adjust it if requested.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll update the fr translation.

core/src/utilsCore.hpp
StringPairT splitDataPointInfo(const QString &info); /* return <[sourcei:]hostaddr, checkid> */
StringPairT splitDataPointInfo(const QString &info); /* return <[source:]hostaddr, checkid> */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

Copy link
Owner

@rchakode rchakode Jul 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a comment for code readability, I think the index of the source is relevant?

docs/deployment-on-kubernetes.md
On success, the deployment does create a Kubernetes **ClusterIP** service named `realopinsiht`.
On success, the deployment does create a Kubernetes **ClusterIP** service named `realopinsight`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brand

resources/i18n/messages.xml
<span id="import-nabios-bpi">${import-nabios-bpi}</span>
<span id="import-nagios-bpi">${import-nagios-bpi}</span>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brand

@rchakode
Copy link
Owner

Hi @jsoref,
Thank you for P, we will review it.

jsoref added 16 commits July 30, 2023 03:28
@jsoref
spelling: from
4a61dbf 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: javascript
44b55fe 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: the
2ceb277 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: adjust
0d7395b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: attachment
8f470b3 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: authenticator
ab58fe2 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: bandwidth
b499f42 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: builtin
0043494 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: children
305d12a 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: confirmation
de9870b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: connect
289f51c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: coord
c17a818 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: criticality
b3f26c7 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: dashboard
7f5625d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: dedicated
4cedfcc 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: deployed
b9268f6 
Signed-off-by: Josh Soref <[email protected]>
jsoref added 10 commits July 30, 2023 04:16
@jsoref
spelling: deployment
e54d6a0 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: disable
2ffd32c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: distinguish
76df6c0 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: every time
9fa8c48 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: group
1edf4c2 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: handle
88e4076 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: horizontal
474ab3e 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: infinity
f801df5 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: info
0c1123d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: initialize
eff2855 
Signed-off-by: Josh Soref <[email protected]>
jsoref added 25 commits July 30, 2023 04:16
@jsoref
spelling: platform
f1877dc 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: priority
7393887 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: querying
51be994 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: realopinsight
911ee81 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: receiving
79d2972 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: response
55692cc 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: separate
abc996b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: series
6759e9b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: settings
1306d02 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: should
3823170 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: slightly
6c581d5 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: source
5fcd280 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: split
c0dca7d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: submenus
5074cca 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: successfully
837873b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: synchronizer
302d2f1 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: thumb
d94a886 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: thumbnail
71c3cf6 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: toolbar
256de31 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: truthy
1da3abf 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: uninitialized
8b14d09 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: updated
e5d6d33 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: visibility
7684741 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: waiting
310fcef 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: writable
ffaf979 
Signed-off-by: Josh Soref <[email protected]>
@rchakode
Copy link
Owner

Dear @jsoref
Thank you again for this huge contribution.
I'll merge it and review the fr translation afterhand.

@rchakode rchakode merged commit 3f5639d into rchakode:main Jul 30, 2023
1 of 2 checks passed
@jsoref jsoref deleted the spelling branch July 30, 2023 08:54
@jsoref jsoref mentioned this pull request Jul 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchakode rchakode rchakode left review comments

Assignees

@jsoref jsoref

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsoref @rchakode