Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Fix components guards #64

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fix components guards #64

merged 1 commit into from
Mar 21, 2024

Conversation

Roming22
Copy link
Member

  • Fix guards on subscriptions leading to them being deleted on updates.
  • Add guard for DH.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Roming22
Copy link
Member Author

/retest

@Roming22
Fix components guards
e16ccda 
* Fix guards on subscriptions leading to them being deleted
  on updates.
* Add guard for DH.
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 21, 2024 •
edited
Loading

@Roming22: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhtap-installer-yamllint e16ccda link false /test rhtap-installer-yamllint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Roming22 Roming22 merged commit 1b2c468 into redhat-appstudio:main Mar 21, 2024
3 of 6 checks passed
@Roming22 Roming22 deleted the bug/argocd/permissions branch March 22, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jduimovich jduimovich Awaiting requested review from jduimovich

@prietyc123 prietyc123 Awaiting requested review from prietyc123

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Roming22