Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

add user-preferences #518

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

InsaneZein
Copy link

part of RHCLOUD-32460. Adds user-preferences

@InsaneZein InsaneZein requested a review from a team as a code owner July 23, 2024 18:23
@InsaneZein
Copy link
Author

@scoheb and @gbenhaim could you please review when you get the chance?

Copy link
Contributor

@ernesgonzalez33 ernesgonzalez33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. Also, you forgot to add your kustomize file and run the build-manifests script

Comment on lines +4 to +5
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines are badly indented. They need to be at the same level of resources

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the entire file indented? Please remove the first spaces in every line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added the kustomize binary, please remove it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants