Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix rendering bug in pantheon when more than one link on the same line and no link text provided (RHIDP-4301) #576

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nickboldt
Copy link
Member

@nickboldt nickboldt commented Oct 3, 2024

What does this PR do?

chore: fix rendering bug in pantheon when more than one link on the same line and no link text provided (RHIDP-4301)

Signed-off-by: Nick Boldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/RHIDP-4301

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…ame line and no link text provided (RHIDP-4301)

Signed-off-by: Nick Boldt <[email protected]>
@nickboldt nickboldt changed the title chore: fix rendering bug in pantheon when... chore: fix rendering bug in pantheon when more than one link on the same line and no link text provided (RHIDP-4301) Oct 3, 2024
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 3, 2024

@nickboldt
Copy link
Member Author

Built with build-ccutil.sh before PR:

image

Built with build-ccutil.sh after PR:

image

@nickboldt
Copy link
Member Author

/cherry-pick release-1.3

@openshift-cherrypick-robot
Copy link
Contributor

@nickboldt: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@Gerry-Forde Gerry-Forde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants