Add option to disable making CLIENT SETINFO command on initialization
#622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DisableClientSetInfo path and test Co-authored-by: Rahul Katre <[email protected]>
rueian
reviewed
Aug 29, 2024
rueian
reviewed
Aug 29, 2024
Co-authored-by: Rueian <[email protected]>
|
Is there a way I can create a release of this change to use in my project? |
I can tag a new alpha version tomorrow. |
|
Hello @rueian, have you had a chance to create an alpha version? We need to consume this ASAP, preferably today or monday/tuesday Sept 2,3. Thanks in advance. |
|
Hi @rahulgkatre, @reagankan, I have tagged the v1.0.46-alpha.1. You can change your go.mod to that. I would also like to know why you need this. I thought the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #620 and adds a
DisableClientSetInfoconstant to be used for theClientSetInfofield ofClientOption.When this constant is used, the
CLIENT SETINFOcommand and relevant paths are skipped during new connection initialization, in order to be compatible with older versions of Redis (<7.2) that do not have theCLIENT SETINFOcommand.