fix: pin black to 23.11.0 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit temporary pins black to 23.11.0 since version https://github.com/psf/black/releases/tag/23.12.0 breaks this action (see #18).
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -3,7 +3,7 @@ FROM python:3-slim | |||
| ENV PYTHONDONTWRITEBYTECODE 1 \ | |||
| PYTHONUNBUFFERED 1 | |||
|
|
|||
| RUN python -m venv venv && . venv/bin/activate && pip install --upgrade pip && venv/bin/pip install --upgrade --no-cache-dir black | |||
| RUN python -m venv venv && . venv/bin/activate && pip install --upgrade pip && venv/bin/pip install --upgrade --no-cache-dir black==23.11.0 | |||
| @@ -3,7 +3,7 @@ FROM python:3-slim | |||
| ENV PYTHONDONTWRITEBYTECODE 1 \ | |||
| PYTHONUNBUFFERED 1 | |||
|
|
|||
| RUN python -m venv venv && . venv/bin/activate && pip install --upgrade pip && venv/bin/pip install --upgrade --no-cache-dir black | |||
| RUN python -m venv venv && . venv/bin/activate && pip install --upgrade pip && venv/bin/pip install --upgrade --no-cache-dir black==23.11.0 | |||
| @@ -3,7 +3,7 @@ FROM python:3-slim | |||
| ENV PYTHONDONTWRITEBYTECODE 1 \ | |||
| PYTHONUNBUFFERED 1 | |||
|
|
|||
| RUN python -m venv venv && . venv/bin/activate && pip install --upgrade pip && venv/bin/pip install --upgrade --no-cache-dir black | |||
| RUN python -m venv venv && . venv/bin/activate && pip install --upgrade pip && venv/bin/pip install --upgrade --no-cache-dir black==23.11.0 | |||
|
It looks like it works (see https://github.com/rickstaa/action-test-repo/actions/runs/7185135823/job/19567748787). |
|
Can we unpin the black version 23.11.0 since there is a major update out there (24.XXX) so that version 23.12.0 won't fail? |
Sure, would you be open to creating a pull request and conducting a few quick tests to verify if the issue outlined in action-black#18 has been resolved? Your help with this would be greatly appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit temporary pins black to 23.11.0 since version https://github.com/psf/black/releases/tag/23.12.0
breaks this action (see #18).