Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new way to pass credentials for SQL backends #113

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

arkbriar
Copy link
Collaborator

  • Add an option metaStore. passSQLCredentialsLegacyMode to control the behaviour. When it's set to false (default), the new way is adopted. Otherwise, it will follow the legacy way.
  • Add an option metaComponent. waitForMetaStore to control whether to have an init container to wait for the PostgreSQL/MySQL to be up before starting the meta pod.

@arkbriar arkbriar requested a review from a team as a code owner August 28, 2024 07:26
@arkbriar
Copy link
Collaborator Author

Should resolve #106

Copy link

@wjf3121 wjf3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkbriar arkbriar added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit 98f62bf Aug 30, 2024
1 check passed
@arkbriar arkbriar deleted the shunjie/issue-106 branch August 30, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants