Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #683 - enable SPDX linter checks #1578

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Fix #683 - enable SPDX linter checks #1578

merged 2 commits into from
Sep 2, 2021

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Sep 2, 2021

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the rizin book with the relevant information (if needed)

Detailed description

Return an error is something is wrong.

Test plan

CI is green

Closing issues

Closes #683

@XVilka XVilka added this to the 0.3.0 milestone Sep 2, 2021
@XVilka XVilka merged commit aacd642 into dev Sep 2, 2021
@XVilka XVilka deleted the spdx-linter-check branch September 2, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ret2libc ret2libc ret2libc approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@wargio wargio Awaiting requested review from wargio wargio is a code owner

Assignees
No one assigned
Labels
infrastructure
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Add SPDX linter CI job
2 participants
@XVilka @ret2libc