fixing path longer on approach

[padhupradheep]

---

Basic Info

Info	Please fill out this column
Ticket(s) this addresses	#4110
Primary OS tested on	(Ubuntu)
Robotic platform tested on	ROX
Does this PR contain AI generated software?	No

---

Description of contribution in a few bullet points

Description of documentation updates required from your changes

---

Future work that may be required in bullet points

For Maintainers:

• Check that any new parameters added are updated in docs.nav2.org
• Check that any significant change is added to the migration guide
• Check that any new features OR changes to existing behaviors are reflected in the tuning guide
• Check that any new functions have Doxygen added
• Check that any new features have test coverage
• Check that any new plugins is added to the plugins page
• If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

[padhupradheep]

almost done!! I want to test it once again in fresh eyes before getting this in.

Sorry, it got longer than expected.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Files	Coverage Δ
...tree/plugins/decorator/path_longer_on_approach.cpp	91.66% <100.00%> (+0.23%)	⬆️

... and 5 files with indirect coverage changes

[SteveMacenski]

I know how that goes sometimes 😉 Thanks for getting to it!

[SteveMacenski]

@padhupradheep if you're back (and if not, ignore this until you're back) can we address this last detail so we can button this up and move the PR out of draft so we can merge it?

[padhupradheep]

I'm back! Will finish it EoD

[padhupradheep]

Gtg now

[mergify]

@padhupradheep, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

[SteveMacenski]

@padhupradheep this PR needs to be rebased to build - there was a rolling API change