Modernize common probes that were using atlas_rucio tables

[voetberg]

Addressing #127 completely and #128 in part

[dchristidis]

I’m afraid I do not understand at all the proposed changes. They appear to completely substitute the existing functionality and behaviour.

[voetberg]

@ericvaandering Can elaborate on the behavior changes in common/check_expired_locked_rules

Otherwise, the updates to common/check_obsolete_replicas are to push monitoring to Prometheus and parameterize the base table of the query.

[dchristidis]

That is certainly not the case.

An execution of common/check_expired_locked_rules will, as the name suggests, list rules that are expired and locked or expired datasets that have locked rules. The proposed changes remove this functionality completely and add metrics that are irrelevant to its current purpose.

Locked expired rules
…
Datasets expired with locked rules
…

An execution of common/check_obsolete_replicas is supposed to update the the RSE usage counters (MERGE INTO atlas_rucio.RSE_USAGE …). That part of the query has been stripped.

[ericvaandering]

I'll have to go look at the history of this. We've been running an early version of this for ages. Not sure I can even reconstruct the history.