Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure CosmosDB NoSql Storage Integrations #16138

Closed

Conversation

aayush3011
Copy link
Contributor

@aayush3011 aayush3011 commented Sep 20, 2024

Description

Storage Integration:

  • Chat Store
  • Index Store
  • KVStore
  • Document Store

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Sep 20, 2024
@aayush3011
Copy link
Contributor Author

@masci @hatianzhang can you please review this PR.

@masci
Copy link
Member

masci commented Sep 23, 2024

@aayush3011 this PR is really too large, any chance you can break it down somehow?

@aayush3011 aayush3011 changed the title Azure CosmosDB Filtered Vector Search, and Storage integration Azure CosmosDB NoSql Storage Integrations Sep 24, 2024
@aayush3011
Copy link
Contributor Author

@masci I have divided the original PR into 3.

@aayush3011
Copy link
Contributor Author

@masci Friendly ping on the status of the PR.

@logan-markewich
Copy link
Collaborator

Going to close this PR in favour of the 3 split out ones

@aayush3011
Copy link
Contributor Author

aayush3011 commented Oct 1, 2024

@logan-markewich This is one of the PR which has changes for the Cosmos DB No SQL Storage Integrations. Please can you re-open this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants