apk: Include recursive libraries via gradle as well
#140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
gradle-library-dependencies
branch
from
df53b08
to
2a13bae
Compare
|
Went over this again and I'm okay with how it is working. |
|
Don't forget to review this with the |
The `gradle` build was only including the target library from `cargo`, but not any (in)direct dependencies like `libc++_shared.so`. Move the logic where we recursively scan all libraries, and pass the result to the `gradle` builder in addition to the existing `apk` builder.
MarijnS95
force-pushed
the
gradle-library-dependencies
branch
from
2a13bae
to
bd2052f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gradlebuild was only including the target library fromcargo, but not any (in)direct dependencies likelibc++_shared.so.Move the logic where we recursively scan all libraries, and pass the result to the
gradlebuilder in addition to the existingapkbuilder.Code is a bit nasty so I might want to improve this before we land it, but at least it works.