gradle: Embed assets in baseAssets "Play Asset Delivery" pack
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Oct 11, 2023
| @@ -14,3 +14,4 @@ dependencyResolutionManagement { | |||
| } | |||
|
|
|||
| include ':app' | |||
| include ':baseAssets' | |||
There was a problem hiding this comment.
Note that this folder/file is optional, and I'm a tad confused that gradle doesn't complain when it doesn't exist.
The app would obviously complain when there's assetPacks = [":baseAssets"] to a pack that doesn't exist, obviously :)
Assets for AABs could be embedded in the application pack but have significant limitations and size constraints. Implement the most simple form of an asset pack that comprises all assets listed in `manifest.yaml` in an `install-time` pack that is a fixed dependency of the app. This makes the files available to `AAssetManager` as soon as the app is started while being exempt of the 150MB limit. This matches the existing "asset embedding" functionality provided by our native APK build. https://developer.android.com/guide/playcore/asset-delivery/integrate-native
MarijnS95
force-pushed
the
gradle-assets
branch
from
d5ebb6e
to
e7edc95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assets for AABs could be embedded in the application pack but have significant limitations and size constraints. Implement the most simple form of an asset pack that comprises all assets listed in
manifest.yamlin aninstall-timepack that is a fixed dependency of the app. This makes the files available toAAssetManageras soon as the app is started while being exempt of the 150MB limit.This matches the existing "asset embedding" functionality provided by our native APK build.
https://developer.android.com/guide/playcore/asset-delivery/integrate-native