Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add request_interrupt_window handling #193

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/ioctls/vcpu.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1403,6 +1403,12 @@ impl VcpuFd {
kvm_run.immediate_exit = val;
}

/// Sets the `request_interrupt_window` flag on the `kvm_run` struct associated with this vCPU to `val`.
pub fn set_kvm_request_interrupt_window(&self, val: u8) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test for this, it can be similar to the one for set_kvm_immediate_exit?

let kvm_run = self.kvm_run_ptr.as_mut_ref();
kvm_run.request_interrupt_window = val;
}

/// Returns the vCPU TSC frequency in KHz or an error if the host has unstable TSC.
///
/// # Example
Expand All @@ -1428,6 +1434,8 @@ impl VcpuFd {
}
}



Comment on lines +1443 to +1444
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are unintentional.

/// Sets the specified vCPU TSC frequency.
///
/// # Arguments
Expand Down