Keep non-public Hyper-V definitions in the MSHV crate #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russell-islam
requested review from
liuw,
NunoDasNeves and
jinankjain
as code owners
Fro sev-snp support we are using some data structure that are non-public. We are not adding those definitions to linux-dom0 header. Signed-off-by: Muminul Islam <[email protected]>
Signed-off-by: Muminul Islam <[email protected]>
russell-islam
force-pushed
the
muislam/snp-2
branch
from
241c1c1
to
99e5a28
Compare
russell-islam
changed the title
russell-islam
force-pushed
the
muislam/snp-2
branch
from
9bb9dbb
to
8e2b96c
Compare
Signed-off-by: Muminul Islam <[email protected]>
russell-islam
force-pushed
the
muislam/snp-2
branch
from
8e2b96c
to
2609217
Compare
NunoDasNeves
approved these changes
Jul 6, 2023
Add some info and links of the SNP definitions are derived from. Signed-off-by: Muminul Islam <[email protected]>
liuw
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Keep non-public MSHV definitions in the MSHV crate Most of this definitions are derived from AMD
specifications and are available in Hyper-V repo as well.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.