Fix issues with new version of zerocopy #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the requirements on [zerocopy](https://github.com/google/zerocopy) to permit the latest version. - [Commits](google/zerocopy@v0.6.0...v0.7.0) --- updated-dependencies: - dependency-name: zerocopy dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Update the bindings using the latest MSHV header files. Signed-off-by: Jinank Jain <[email protected]>
Starting zerocopy version v0.7 it is necessary to explicity include feature derive otherwise derive FromBytes and AsBytes are not visible. While doing that there was another breaking change in zerocopy which requires explicit deriving of FromZeroes on deriving FromBytes.t Signed-off-by: Jinank Jain <[email protected]>
With recent rust version clippy got strict and founding errors in the code generated by bindgen. So we need to another filter in the allowlist to make clippy happy. Signed-off-by: Jinank Jain <[email protected]>
jinankjain
requested review from
russell-islam,
liuw and
NunoDasNeves
as code owners
liuw
approved these changes
Aug 28, 2023
NunoDasNeves
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
With new version of zerocopy there are multiple breaking changes that would need fixing on mshv-bindings side.
This PR is a super set of #112
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.