mshv-bindings: Refactor codebase to add support for ARM64 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinankjain
requested review from
russell-islam,
liuw and
NunoDasNeves
as code owners
jinankjain
force-pushed
the
arm64_cleanup
branch
from
9af4e4c
to
e3393ba
Compare
|
Did you try to build CLH with mshv? |
|
Actually, CLH build was failing with the latest mshv commit, vfio crates also needs to be updated. I created a PR in CLH upstream |
russell-islam
approved these changes
Apr 16, 2024
|
@jinankjain Please fix the merge conflict. |
In future, we are planning to add support for arm64. So bindings and definitions related to x86 needs to move into a separate directory of it's own. There is no functional change code is just moved into a different directory. Signed-off-by: Jinank Jain <[email protected]>
Currently generate_bindings.py hardcodes the architecture to x86. Generalize the script by passing architecture as an argument to the script. Signed-off-by: Jinank Jain <[email protected]>
Signed-off-by: Jinank Jain <[email protected]>
jinankjain
force-pushed
the
arm64_cleanup
branch
from
e3393ba
to
e421d17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Move arch specific code into its separate directory structure and generate bindings for ARM64.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.