Build Cloud-hypervisor on every PR #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muminul Islam <[email protected]>
russell-islam
requested review from
liuw,
NunoDasNeves and
jinankjain
as code owners
Signed-off-by: Muminul Islam <[email protected]>
russell-islam
force-pushed
the
muislam/clh-build
branch
from
b681d9c
to
7ba7d3c
Compare
NunoDasNeves
approved these changes
Apr 26, 2024
|
Are we ready to make stability commitments? Can we also build vfio crates? |
I did not think about stability commitment but we need to build CLH for mshv chnages as I found many times clh build breaks. We can always disable this action if needed. I can add vfio in another pr. |
liuw
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.