Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate new bindings #162

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Generate new bindings #162

merged 2 commits into from
Aug 29, 2024

Conversation

russell-islam
Copy link
Collaborator

Summary of the PR

Please summarize here why the changes in this PR are needed.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@NunoDasNeves
Copy link
Collaborator

@russell-islam Generate for ARM64 too and check it builds

@russell-islam
Copy link
Collaborator Author

russell-islam commented Aug 28, 2024

@russell-islam Generate for ARM64 too and check it builds

I did and it builds fine.

@NunoDasNeves
Copy link
Collaborator

@russell-islam Generate for ARM64 too and check it builds

I did and it builds fine.

Add the new ARM64 bindings to this PR

@russell-islam russell-islam merged commit 1b16832 into main Aug 29, 2024
6 checks passed
@russell-islam russell-islam deleted the muislam/gen-bind branch August 29, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants