mshv-bindings: derive AsBytes and FromBytes for various structures #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuw
requested review from
russell-islam,
NunoDasNeves and
jinankjain
as code owners
russell-islam
previously approved these changes
Oct 20, 2022
|
Looks like the CI is down again. |
Derive AsBytes and FromBytes for various structures Signed-off-by: Wei Liu <[email protected]> Signed-off-by: Muminul Islam <[email protected]>
russell-islam
dismissed stale reviews from NunoDasNeves and themself
via
7a48e97
russell-islam
force-pushed
the
derive-as-from-bytes
branch
from
1e4c664
to
7a48e97
Compare
russell-islam
approved these changes
Oct 22, 2022
jinankjain
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
See #65
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
unsafecode is properly documented.