Expose VmType to the public interface #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinankjain
requested review from
russell-islam,
liuw and
NunoDasNeves
as code owners
russell-islam
approved these changes
Jul 2, 2023
NunoDasNeves
reviewed
Jul 6, 2023
liuw
approved these changes
Jul 6, 2023
Since VmType would be use by Cloud Hypervisor while creating the VM. So we need to expose it to the public interface. Signed-off-by: Jinank Jain <[email protected]>
This is required to convert a u64 to VmType. On the cloud hypervisor side, we would have a u64 as vm type which needs to be converted to VmType when invoking create_vm from MSHV crate. Signed-off-by: Jinank Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
VmType is needed by cloud hypervisor when trying to create a VM. Thus, we need to expose it to the public interface along with it also add support to convert u64 to VmType.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.