Make Dockerfile multi-stage #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhost-device-sound has an ALSA audio backend that dynamically links to library libasound2 and also needs its development headers. Signed-off-by: Manos Pitsidianakis <[email protected]>
The system library package for libpipewire-0.3 in the used ubuntu image is not recent enough for the pipewire bindings crate vhost-device-sound uses, so build and install it manually. Signed-off-by: Manos Pitsidianakis <[email protected]>
By making the build multi-stage, we get several benefits: - Independent stages can run in parallel. - Stages are separate layers which are cached. - Changes to one stage don't cause rebuilds on stages that don't depend on it. - Only files from the final stage end up in the final image. Signed-off-by: Manos Pitsidianakis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #88
Obsoletes #89
Summary of the PR
The tricky part is making sure every necessary thing ends up in the image.
Right now
/usrand/etcare copied entirely which should cover most things.Doing an
apt removeforlibgpiodandpipewirebuild-only dependencies will also bring the image size down.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.