feat(build_container): added musl-tools #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
requested review from
andreeaflorescu,
lauralt,
stefano-garzarella,
stsquad,
roypat and
JonathanWoollett-Light
as code owners
ShadowCurse
force-pushed
the
add_musl_tools
branch
3 times, most recently
from
1eec320
to
767879e
Compare
Added musl-tools package. This is required for rust-vmm/vhost#218 which adds the userfaultfd crate which fails to compile without this. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
add_musl_tools
branch
from
767879e
to
54f9ce3
Compare
JonathanWoollett-Light
approved these changes
Jan 2, 2024
stefano-garzarella
approved these changes
Jan 2, 2024
ShadowCurse
added a commit
to ShadowCurse/rust-vmm-container
that referenced
this pull request
Jan 3, 2024
This commit is an addition to the rust-vmm#97 PR and helps musl-tools to find linux headers. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
added a commit
to ShadowCurse/rust-vmm-container
that referenced
this pull request
Jan 3, 2024
This commit is an addition to the rust-vmm#97 PR and helps musl-tools to find linux headers. Signed-off-by: Egor Lazarchuk <[email protected]>
4 tasks
roypat
pushed a commit
that referenced
this pull request
Jan 3, 2024
This commit is an addition to the #97 PR and helps musl-tools to find linux headers. Signed-off-by: Egor Lazarchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Added musl-tools package. It is needed for some rust crates to compile for musl target.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.