Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add riscv64 support #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add riscv64 support #72

wants to merge 1 commit into from

Conversation

kxxt
Copy link

@kxxt kxxt commented Mar 15, 2024

Summary of the PR

Add riscv64 support.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@alindima
Copy link
Collaborator

thanks for the contribution. while it overall looks good, we don't have any riscv support in the CI. Without that, I don't think we can merge such PRs, since it would basically result in untested code being released.
I noticed at least one other rust-vmm crate which has open PRs for riscv support also. Is there such planned support?
CC: @andreeaflorescu (mentioning you since you may have an opinion on this)

@kxxt
Copy link
Author

kxxt commented Mar 22, 2024

while it overall looks good,

Thank!

while it overall looks good, we don't have any riscv support in the CI.

It looks like there's a PR adding that: rust-vmm/rust-vmm-ci#148

Without that, I don't think we can merge such PRs, since it would basically result in untested code being released.

I think another possible way could be merging riscv64 support and labeling riscv64 as a community supported and not officially tested architecture in the documentation.

BTW here is a test log on riscv64: https://paste.rs/Oyi0p

petreeftime
petreeftime previously approved these changes Mar 26, 2024
kxxt added a commit to kxxt/archriscv-packages that referenced this pull request May 10, 2024
- Add to qemu-user blacklist because qemu doesn't implement ptrace so
  test will fail in qemu-user
- Disable seccomp-bpf feature because upstream seccompiler doesn't
  support riscv64 and it appears that they don't plan to merge my PR
  before riscv CI is setup: rust-vmm/seccompiler#72
- I am the author of this software BTW :)
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request May 10, 2024
- Add to qemu-user blacklist because qemu doesn't implement ptrace so
  test will fail in qemu-user
- Disable seccomp-bpf feature because upstream seccompiler doesn't
  support riscv64 and it appears that they don't plan to merge my PR
  before riscv CI is setup: rust-vmm/seccompiler#72
- I am the author of this software BTW :)
kxxt added a commit to kxxt/archriscv-packages that referenced this pull request Sep 18, 2024
- Fix rotten
- Use my fork of seccompiler for enabling seccomp-bpf feature, previous
  upstream PR: rust-vmm/seccompiler#72
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Sep 18, 2024
- Fix rotten
- Use my fork of seccompiler for enabling seccomp-bpf feature, previous
  upstream PR: rust-vmm/seccompiler#72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants