vsock: require virtio-vsock 0.2.1 #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 0.2.1 version of virtio-vsock crate contains a fix [1] needed to properly work with the virtio-vsock driver provided by Linux v6.3 and later (originally the new driver was supposed to be in v6.2, but it was postponed). The fix was just a quick workaround, but in the future more work will be needed in the virtio-vsock crate to not have a Linux-only specific implementation of VsockPacket, as described in this issue [2]. [1] rust-vmm/vm-virtio#207 [2] rust-vmm/vm-virtio#216 Signed-off-by: Stefano Garzarella <[email protected]>
stefano-garzarella
requested review from
mathieupoirier,
stsquad and
vireshk
as code owners
stsquad
approved these changes
Jan 16, 2023
mathieupoirier
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
The 0.2.1 version of virtio-vsock crate contains a fix needed to properly work with the virtio-vsock driver provided by Linux v6.3 and later (originally the new driver was supposed to be in v6.2, but it was postponed).
The fix was just a quick workaround, but in the future more work will be needed in the virtio-vsock crate to not have a Linux-only specific implementation of VsockPacket, as described in this issue .
Signed-off-by: Stefano Garzarella [email protected]
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.