Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Poll safe creation info even when switching networks #4294

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #4293

How this PR fixes it

  • Emits the chainId with the SUCCESS and INDEXED safe creation event
  • Uses that chainId inside the success modal instead of the current chain id

How to test it

  1. Create a safe on network A
  2. Switch to a safe on network B
  3. Observe the success screen showing network A info correctly once the safe has been deployed

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Oct 1, 2024

@@ -189,7 +189,7 @@ const delay = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms))
* @param txHash
* @param maxAttempts
*/
async function retryGetTransaction(provider: Provider, txHash: string, maxAttempts = 6) {
async function retryGetTransaction(provider: Provider, txHash: string, maxAttempts = 8) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increased this a bit because I saw FAILED events in some cases when it took a bit longer to index a safe.

Copy link

github-actions bot commented Oct 1, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 954.87 KB (🟡 +50 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Oct 1, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.09% 12000/15366
🔴 Branches 58.17% 3084/5302
🟡 Functions 65.09% 1889/2902
🟡 Lines 79.63% 10831/13601

Test suite run success

1484 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from ebd4125

@usame-algan usame-algan changed the title fix: Poll safe creation info after creation reliably fix: Poll safe creation info even when switching networks Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Success screen shows wrong chain when switching chains during safe creation
2 participants