Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): special notes section #161

Merged
merged 1 commit into from
Oct 16, 2019
Merged

docs(readme): special notes section #161

merged 1 commit into from
Oct 16, 2019

Conversation

noelmcloughlin
Copy link
Member

Some formulas have unexpected defaults so README should flag this per "Special notes".

See saltstack-formulas/golang-formula#26 for implementation example

This PR is independent of #21 though related.

@aboe76 aboe76 requested a review from myii August 17, 2019 19:43
@aboe76 aboe76 changed the title docs(reamde): special notes section docs(readme): special notes section Sep 13, 2019
@myii myii changed the base branch from develop to master October 13, 2019 21:17
@myii myii merged commit ed8d0dd into saltstack-formulas:master Oct 16, 2019
@myii
Copy link
Member

myii commented Oct 16, 2019

Sorry for the delay, @noelmcloughlin -- got this merged. Thanks for the review, @aboe76.

@saltstack-formulas-travis

🎉 This PR is included in version 3.3.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants