[3006.x] backport: Update SSH wrappers, wrap more funcs #66661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit ddc1197)
This is a 1:1 copy of the execution module, incl. tests... (cherry picked from commit 47a609f)
The wrapper has diverged significantly from the module. * `option` did not check grains * `option` did not have `omit_all` and `wildcard` parameters * `get` missed several parameters: `delimiter`, `merge` and all `omit_*` * There was no wrapping function for `items`. (cherry picked from commit 8356be8)
(cherry picked from commit 82f90e2)
(cherry picked from commit 18bc40c)
`ordered=False` would not have worked before (cherry picked from commit 5e16d84)
The test fix was part of 6a71510
salt-project-bot-prod-environment
bot
changed the title
dwoz
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Backports most wrapper fixes from #65517 as per #65067 (comment).
Does not include the rewritten
cpand newcmdwrapper (relies on the former)What issues does this PR fix or reference?
Fixes: #61100
Fixes: #56441
Fixes: #65067
Fixes: #61143
Fixes: #50196
Fixes: #51605
Fixes: #65630
The following are already fixed in 3007.x, but not backported to 3006.x because it would be more involved:
They can be closed manually.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes