[BUG] Exception when receive messages from javascript #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsdearaujo
changed the title
davidsdearaujo
changed the title
sarbagyastha
requested changes
Sep 24, 2024
| String handleJsMessage(Object? jsMessage) { | ||
| return switch (jsMessage) { | ||
| String message => message, | ||
| Map map => jsonEncode(map), |
There was a problem hiding this comment.
if it's already a map, do we need to encode and decode ?
There was a problem hiding this comment.
This is not always a map... I'm encoding at this moment to make as less changes as possible in the existing logic
There was a problem hiding this comment.
I've separated this logic into two distinct handlers in this commit: Improve web controller's JS message deserialization
| return switch (jsMessage) { | ||
| String message => message, | ||
| Map map => jsonEncode(map), | ||
| Object? data => throw Exception( |
There was a problem hiding this comment.
Implemented in this commit: refactor: fail silently when handleJsMessage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Javascript is returning messages that are
Mapinstead ofStringand it's throwing an exception.Snapshot