Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router: implement spaces.beforeXxxArgInParens #3612

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Router: implement spaces.beforeXxxArgInParens #3612

merged 2 commits into from
Aug 22, 2023

Conversation

kitbellew
Copy link
Collaborator

Fixes #3385. Fixes #3607.

@kitbellew kitbellew requested a review from tgodzik August 13, 2023 05:18
@kitbellew kitbellew changed the title Router: implement spaces.beforeXxxArgInParens Router: implement spaces.beforeXxxArgInParens Aug 18, 2023
@kitbellew
Copy link
Collaborator Author

@tgodzik any thoughts on this?

tgodzik
tgodzik approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we needed a new setting (as always), but I guess this sounds resonable.

@kitbellew kitbellew merged commit 4d3f873 into scalameta:master Aug 22, 2023
8 checks passed
@kitbellew kitbellew deleted the 3385 branch August 22, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not insert space after arity-0 infix operator, before parens feat: add more options for DSL
2 participants
@kitbellew @tgodzik