Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RedundantParens: keep w/ dotless select in infix #4386

Merged
merged 2 commits into from
Oct 2, 2024
+15 −0
Merged

RedundantParens: keep w/ dotless select in infix #4386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0501926
Test redundant parens with dotless select in infix
kitbellew Oct 2, 2024
d01311c
RedundantParens: keep w/ dotless select in infix
kitbellew Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scalafmt-core/shared/src/main/scala/org/scalafmt/rewrite/RedundantParens.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ class RedundantParens(implicit val ftoks: FormatTokens)
case _: Lit | _: Name | _: Term.Interpolate => true
case _: Term.PartialFunction => true
case _: Term.AnonymousFunction => false
case t: Term.Select if !isSelectWithDot(t) => false
case _ => style.rewrite.redundantParens.infixSide.isDefined
}

Expand Down
14 changes: 14 additions & 0 deletions scalafmt-tests/shared/src/test/resources/rewrite/RedundantParens.stat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1664,3 +1664,17 @@ object a {
_.getAbsolutePath
)
}
<<< #4133 keep parens around dotless select in infix, rhs
rewrite.redundantParens.infixSide = all
===
def newLine: Parser[String] = namedError("\r" ~> ("\n" ?), "End of line expected")
>>>
def newLine: Parser[String] =
namedError("\r" ~> ("\n" ?), "End of line expected")
<<< #4133 keep parens around dotless select in infix, lhs
rewrite.redundantParens.infixSide = all
===
def newLine: Parser[String] = namedError(("\r" ?) ~> "\n", "End of line expected")
>>>
def newLine: Parser[String] =
namedError(("\r" ?) ~> "\n", "End of line expected")
Loading