Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the provider deps into an optional feature. #98

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Conversation

wRAR
Copy link
Contributor

@wRAR wRAR commented Jul 3, 2023

Fixes #97

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #98 (a15e224) into main (3c82d07) will increase coverage by 1.31%.
The diff coverage is n/a.

❗ Current head a15e224 differs from pull request most recent head eaa3409. Consider uploading reports for the commit eaa3409 to get more accurate results

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   97.14%   98.45%   +1.31%     
==========================================
  Files          18        9       -9     
  Lines        1294      647     -647     
==========================================
- Hits         1257      637     -620     
+ Misses         37       10      -27     

see 13 files with indirect coverage changes

@kmike kmike merged commit a3f3e15 into main Jul 4, 2023
14 checks passed
@wRAR wRAR deleted the scrapy-poet-optional branch July 13, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for old Scrapy is incompatible with scrapy-poet
3 participants