NDEV-70 Action buttons are not translated #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jarn.jsi18nuses the first matched catalog instead of merging the translation resources available for the same domain and language. More info: jarn.jsi18n uses the first matched catalogThis causes that action buttons, as well as other translations retrieved javascript do not render properly in some cases. With this Pull Request, the function from jarn.jsi18n has been overriden, so it takes into account now all translation resources from a given domain and language.
A Pull Request to the official repos has been created too: collective/jarn.jsi18n#2
Note
jarn.jsi18nstores the catalog for 24 hours by default. To x-check this PR, you can set the time-to-live by calling jarn.i18n.setTTL(millis) passing in milliseconds for how long the local storage cache should remain valid. Note that if local storage is supported, and the cache has not expired, the browser will NOT reload a catalog.