FIX Don't try to install uninstallable libasound2 #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/1.14/no-libasound
branch
from
21465f0
to
4f3b331
Compare
emteknetnz
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/silverstripe/recipe-kitchen-sink/actions/runs/11060345315/job/30730719567
libasound2isn't installable on its own for Ubuntu 24 which is the newubuntu:latestin GitHub Actions, which is what we set all our CI to use.I've read a bunch of places that people tried installing one of the packages that the error message says includes it, but they either couldn't install them or found they still had errors.
Tested this PR in https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/11061184264 and things are going green!
Remaining CI failures in that build aren't related.
Issue