FIX Ensure nvmdir exists #42
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #41
Fixes https://github.com/silverstripe/silverstripe-versioned-admin/actions/runs/11042923925/job/30738441066
Not sure why the dir existed when I tested the previous PR (looks like nvm is pre-installed for creative-commoners for some reason??). But tested this PR separately and it clearly indicates that it created the dir this time and worked as expected thereafter: https://github.com/silverstripe/silverstripe-lumberjack/actions/runs/11063333839/job/30739509770
Also need to source it with
--no-useto avoid anexit 3that seems to happen if you source nvm while in a directory with a.nvmrcwhen the version of npm in that.nvmrcfile hasn't been installed yet.Why did this all start breaking suddenly?
Turns out nvm was always pre-installed with ubuntu 22, but isn't with ubuntu 24. We thought we were installing it from scratch, but we were just updating it.
Issue