Add Upload Request Timeout, Fix API Error Messages #230
Conversation
Generated by 🚫 Danger Swift against 832ecb5 |
… instead of an async throw stream. Update affected code
# Conflicts: # Sources/SmileID/Classes/Util.swift
tobitech
changed the title
| @@ -3,5 +3,5 @@ import Foundation | |||
| protocol RestServiceClient { | |||
| func send<T: Decodable>(request: RestRequest) async throws -> T | |||
| func multipart<T: Decodable>(request: RestRequest) async throws -> T | |||
| func upload(request: RestRequest) async throws -> AsyncThrowingStream<UploadResponse, Error> | |||
There was a problem hiding this comment.
Maybe document this as well?
| do { | ||
| let urlRequest = try request.getUploadRequest() | ||
| let configuration = URLSessionConfiguration.default | ||
| configuration.timeoutIntervalForRequest = uploadRequestTimeout |
There was a problem hiding this comment.
@tobitech on android this applies to all requests not just the upload, not sure if I missed the discussion but could there be a reason why we're only usingthe timeout on the upload only?
…tworking layer. Add some documentation.
Story: https://app.shortcut.com/smileid/story/13466/
Summary
Known Issues
Confirm that timeout errors are handled.
Test Instructions
uploadRequestTimeoutargument to the SmileID initialiser like 1sec.Screenshot
https://portal.usesmileid.com/admin/job/production/172668761