Skip to content

Commit

Permalink
Merge branch 'envoy-gloo-bump-for-inja' of ssh://github.com/solo-io/g…
Browse files Browse the repository at this point in the history
…loo into envoy-gloo-bump-for-inja
  • Loading branch information
jbohanon committed Jul 14, 2023
2 parents 7f0b6f6 + a76b87f commit 9dd18b6
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/codegen.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,6 @@ jobs:
id: changed-files
uses: tj-actions/changed-files@v37
- name: Check for DO_NOT_SUBMIT
# documentation for where we get the list of files to pass into the script:
# https://github.com/marketplace/actions/changed-files?version=v37#outputs
run: ./ci/do-not-submit.sh ${{ steps.changed-files.outputs.all_changed_files }}
6 changes: 6 additions & 0 deletions changelog/v1.15.0-beta21/do-not-submit-fixes.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
changelog:
- type: NON_USER_FACING
description: >-
Check .proto files for DO_NOT_SUBMIT and do not attempt to check deleted files
skipCI-kube-tests:true
skipCI-docs-build:true
8 changes: 4 additions & 4 deletions ci/do-not-submit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# of those files for comments including the DO_NOT_SUBMIT keyword. If the
# keyword is present, the script exits with -1.
#
# This initial implementation only checks *.go files for single-line comments
# This implementation checks go.mod, *.go, and *.proto files for single-line comments
# (i.e. starting with // rather than /* ... */).
#
# This script is invoked by .github/workflows/do-not-submit.yaml
Expand All @@ -18,11 +18,11 @@ NEWLINE=$'\n'
OUTPUT=""
DO_NOT_SUBMIT_REGEX="[[:space:]]*//[[:space:]]*DO_NOT_SUBMIT"

# Keeps track of number of *.go files (as opposed to all files provided)
# Keeps track of number of go.mod, *.go, and *.proto files (as opposed to all files provided)
file_count=0
for filename in "$@"; do
# Only check *.go files for now
if [[ "$filename" == *".go" || "$filename" == *"go.mod" ]]; then
if [[ "$filename" == *".go" || "$filename" == *"go.mod" || "$filename" == *".proto" ]]; then
((file_count++))
line_number=1
while IFS= read -r line; do
Expand All @@ -40,4 +40,4 @@ if [[ "$OUTPUT" == "" ]]; then
else
echo "$OUTPUT"
exit -1
fi
fi

0 comments on commit 9dd18b6

Please sign in to comment.