Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage the GatewayClass Accepted Status Condition #10093

Open
danehans opened this issue Sep 23, 2024 · 0 comments · May be fixed by #10140
Open

Manage the GatewayClass Accepted Status Condition #10093

danehans opened this issue Sep 23, 2024 · 0 comments · May be fixed by #10140
Assignees
Labels
Area: K8S Gateway API Issues related to the Kubernetes Gateway API post-plan/1.18 release/1.18 Type: Enhancement New feature or request

Comments

@danehans
Copy link

danehans commented Sep 23, 2024

Gloo Edge Product

Open Source

Gloo Edge Version

1.17.7

Is your feature request related to a problem? Please describe.

The GatewayClass reconciler will unconditionally set the Accepted: True status condition for managed GatewayClasses. According to the GatewayClass spec, this status condition type should be set to false for the following reasons:

“InvalidParameters”
“Unsupported”
“UnsupportedVersion”

Describe the solution you'd like

Update the ReconcileGatewayClasses() method to implement the following:

  1. Reject the GatewayClass with the Accepted: False and an “InvalidParameters” reason if the GatewayClass references an invalid GatewayParameters resource.
  2. Reject the GatewayClass with the Accepted: False and an “ UnsupportedVersion” reason if the installed Gateway API CRDs do not have the gateway.networking.k8s.io/bundle-version annotation, or have it set to a version that is not recognized or supported (xref).

Describe alternatives you've considered

N/A

Additional Context

This functionality is required to be compliant with the spec.

┆Issue is synchronized with this Asana task by Unito

@danehans danehans added Type: Enhancement New feature or request Area: K8S Gateway API Issues related to the Kubernetes Gateway API labels Sep 23, 2024
@danehans danehans self-assigned this Sep 26, 2024
@danehans danehans linked a pull request Oct 1, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: K8S Gateway API Issues related to the Kubernetes Gateway API post-plan/1.18 release/1.18 Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants