Adds Support for GatewayClass SupportedVersion Condition #10140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
…ndition Previously, the gateway2 controller would unconditionally set the GatewayClass Accepted condition to `true`. This PR adds a watch for the Gateway API CRDs that triggers GatewayClass reconciliation. The `ReconcileGatewayClasses()` method was updated to set GatewayClass status conditionas based on the Gateway API spec. Fixes: solo-io#10092 Signed-off-by: Daneyon Hansen <[email protected]>
danehans
commented
Oct 1, 2024
| @@ -32,6 +32,10 @@ const ( | |||
| ) | |||
|
|
|||
| var ( | |||
| // SupportedVersions specifies the supported versions of Gateway API. | |||
| // [TODO] Remove "v1.0.0-rc1" when https://github.com/solo-io/gloo/issues/10115 is fixed. | |||
| SupportedVersions = []string{"v1.1.0", "v1.0.0", "v1.0.0-rc1"} | |||
There was a problem hiding this comment.
Note that v1.1.0 was added to this list due to #10121
There was a problem hiding this comment.
cc @sam-heilbron - this is somewhat relevant to the conversation we've been having around ironing out our GW API support matrix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the gateway2 controller would unconditionally set the GatewayClass Accepted condition to
True. This PR adds a watch for the Gateway API CRDs that triggers GatewayClass reconciliation. TheReconcileGatewayClasses()method was updated to set GatewayClass status conditions based on the Gateway API spec.Fixes: #10092
Part Of: #10093
Testing steps
Checklist:
BOT NOTES:
resolves #10092