Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose custom request headers with GrpcHealthCheck #8490

Closed
AkshayAdsul opened this issue Jul 20, 2023 · 3 comments · Fixed by #8511
Closed

Expose custom request headers with GrpcHealthCheck #8490

AkshayAdsul opened this issue Jul 20, 2023 · 3 comments · Fixed by #8511
Assignees
Labels

Comments

@AkshayAdsul
Copy link

Version

None

Is your feature request related to a problem? Please describe.

Gloo Edge v1.14.2 does not support custom request headers with [GrpcHealthCheck] (

) where as the version of Envoy (v1.25.6) it uses does support the feature in the config API config.core.v3.HealthCheck.GrpcHealthCheck
Could you please help expose those configurations in Upstream CRD?

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional Context

This is a blocker for customer to onboard gRPC applications

@sam-heilbron
Copy link
Contributor

@SantoDE and I spoke on slack (https://solo-io-corp.slack.com/archives/C03L190TQDA/p1689844521806349) and agreed this is not a release blocker.

@davidjumani
Copy link
Contributor

davidjumani commented Aug 2, 2023

Added to 1.15 via #8511 and part of v1.15.0-beta24
Added to 1.14 via #8530 and part of v1.14.14

@davidjumani davidjumani reopened this Aug 2, 2023
@davidjumani
Copy link
Contributor

davidjumani commented Aug 3, 2023

Added in enterprise 1.14 and part of v1.14.8
Added in enterprise 1.15 and will be part of v1.15.0 when released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants