Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: Expose initial_metadata in GrpcHealthCheck [1.14] #8530

Merged
merged 3 commits into from
Aug 1, 2023
Merged

backport: Expose initial_metadata in GrpcHealthCheck [1.14] #8530

merged 3 commits into from
Aug 1, 2023

Conversation

davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Aug 1, 2023 •
edited by solo-changelog-bot bot
Loading

Description

Backport of #8511

Context

#8490

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

BOT NOTES:
resolves #8490

@davidjumani @soloio-bulldozer @nfuden
feat: Expose initial_metadata in GrpcHealthCheck (#8511)
ffe0b79 
* feat: Expose initial_metadata in GrpcHealthCheck

* Trigger CI

* Fix uneven whitespace

Co-authored-by: Nathan Fudenberg <[email protected]>

* Adding changelog file to new location

* Avoid code duplcation

* Removing duplicate changelog

* fix test

* Add check for forbidden custom headers

---------

Co-authored-by: David Jumani <[email protected]>
Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: Nathan Fudenberg <[email protected]>
Co-authored-by: changelog-bot <changelog-bot>
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Aug 1, 2023
@solo-changelog-bot
Copy link

Issues linked to changelog:
#8490

@davidjumani davidjumani marked this pull request as ready for review August 1, 2023 15:16
@davidjumani davidjumani requested a review from a team as a code owner August 1, 2023 15:16
@davidjumani davidjumani changed the title feat: Expose initial_metadata in GrpcHealthCheck (#8511) backport: Expose initial_metadata in GrpcHealthCheck (#8511) Aug 1, 2023
@davidjumani davidjumani changed the title backport: Expose initial_metadata in GrpcHealthCheck (#8511) backport: Expose initial_metadata in GrpcHealthCheck [1.14] Aug 1, 2023
@davidjumani davidjumani force-pushed the backport-expose-initialmetadata-grpchealthcheck branch from 871f019 to fc717b0 Compare August 1, 2023 15:24
sam-heilbron
sam-heilbron approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@sam-heilbron sam-heilbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

pkg/utils/api_conversion/api_conversion_suite_test.go
. "github.com/onsi/gomega"
)

func TestChannelutils(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ApiConversion instead of Channelutils?

@soloio-bulldozer soloio-bulldozer bot merged commit cdfdb14 into v1.14.x Aug 1, 2023
12 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the backport-expose-initialmetadata-grpchealthcheck branch August 1, 2023 21:03
@davidjumani davidjumani mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elcasteel elcasteel elcasteel approved these changes

@sam-heilbron sam-heilbron sam-heilbron approved these changes

Assignees
No one assigned
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidjumani @elcasteel @sam-heilbron