Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentelemetry span name #10123

Draft
wants to merge 16 commits into
base: v1.17.x
Choose a base branch
from
Draft

Opentelemetry span name #10123

wants to merge 16 commits into from

Conversation

ashishb-solo
Copy link
Contributor

@ashishb-solo ashishb-solo commented Sep 27, 2024

Description

Implement control plane API for modifying span names for tracing purposes.

Context: solo-io/envoy-gloo#368

API changes

Add span_transformer.name to the transformation filter.

Code changes

Ensure that the span_transformer field is copied from the Gloo API to the Envoy API

CI changes

None

Docs changes

TODO: we should update https://docs.solo.io/gloo-edge/latest/guides/traffic_management/request_processing/transformations/ to explain that transforms can also modify traces.

Context

This is an incremental update to implementing a control plane API for updating the span name for opentelemetry traces.

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Sep 27, 2024
@ashishb-solo ashishb-solo removed the keep pr updated signals bulldozer to keep pr up to date with base branch label Sep 27, 2024
@solo-changelog-bot
Copy link

Issues linked to changelog:
#9848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant