-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opentelemetry span name #10123
Draft
ashishb-solo
wants to merge
16
commits into
v1.17.x
Choose a base branch
from
opentelemetry-span-name
base: v1.17.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Opentelemetry span name #10123
+1,817
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
keep pr updated
signals bulldozer to keep pr up to date with base branch
label
Sep 27, 2024
ashishb-solo
removed
the
keep pr updated
signals bulldozer to keep pr up to date with base branch
label
Sep 27, 2024
Issues linked to changelog: |
…o opentelemetry-span-name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement control plane API for modifying span names for tracing purposes.
Context: solo-io/envoy-gloo#368
API changes
Add
span_transformer.name
to the transformation filter.Code changes
Ensure that the
span_transformer
field is copied from the Gloo API to the Envoy APICI changes
None
Docs changes
TODO: we should update https://docs.solo.io/gloo-edge/latest/guides/traffic_management/request_processing/transformations/ to explain that transforms can also modify traces.
Context
This is an incremental update to implementing a control plane API for updating the span name for opentelemetry traces.
Interesting decisions
Testing steps
Notes for reviewers
Checklist: