Accept non-trusted certificates option #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeatrix
approved these changes
Sep 27, 2024
| @@ -18,6 +18,7 @@ public void ForceBindingsUpdate() | |||
| // This is a workaround to get bindings updated. The second solution is to use NotifyPropertyChange for every TextBox in the Xaml, but current solution is a little more "clean" - everything is clearly visible in a one place. | |||
| SourcegraphUrlTextBox.GetBindingExpression(TextBox.TextProperty)?.UpdateSource(); | |||
| ConfigurationsTextBox.GetBindingExpression(TextBox.TextProperty)?.UpdateSource(); | |||
| AcceptNonTrustedCertCheckBox.GetBindingExpression(CheckBox.IsCheckedProperty)?.UpdateSource(); | |||
There was a problem hiding this comment.
Not needed. Only TextBox controls do need those additional binding calls.
| @@ -449,6 +452,35 @@ private void OnAfterCloseSolution(object sender, EventArgs e) | |||
| } | |||
| } | |||
|
|
|||
| private async Task TestServerConnection(string serverAddress) | |||
There was a problem hiding this comment.
Would be great to add modal dialog that will show the warning, and two options button, like:
"Do you want to change non-trusted certificate policy?"
"SSL certificate problem: self-signed certificate in servers certificate chain. Consider using 'Accept non-trusted certificates' option in Cody settings window."
- "Change"
- "Cancel"
After clicking the first button, we will display the options page via ShowOptionPage(typeof(GeneralOptionsPage)); and user could change the setting immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSE https://linear.app/sourcegraph/issue/CODY-3900/add-accept-non-trusted-certificates-option-in-visual-studio