CI for UI Tests Infrastructure Update #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_close_and_reopen_window() test.
…() and Solution_Name_Is_Added_To_Chat_Input()
- Introduced SemaphoreSlim() for synchronization - Playwright related properties (Browser, Context, Page and Playwright) are now static Added CollectionBehavior.CollectionPerAssembly and DisableTestParallelization = true Turned off ChatLoggedBasicTests
PiotrKarczmarz
changed the title
PiotrKarczmarz
changed the title
…d(IVsCredentialKey credentialKey, String credentialValue) method.
abeatrix
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Looks great in the CI! Let's document how dev can add a new test and what steps devs should take when the CI fail in our CONTRIBUTING docs in a follow up. Will create a linear issue for this, thank you so much!
| { | ||
| } | ||
|
|
||
| //[VsFact(Version = VsVersion.VS2022)] |
There was a problem hiding this comment.
This is for XUnit logger, which is passing calls to our Logger. Thanks to it we have nice, detailed logs from tests https://github.com/sourcegraph/cody-vs/actions/runs/10814320609/job/30000502786#step:8:88
| NoBuild = true, | ||
| NoRestore = true | ||
| }); | ||
| // DotNetTest("./Cody.VisualStudio.Tests/bin/Debug/Cody.VisualStudio.Tests.dll", new DotNetTestSettings |
There was a problem hiding this comment.
Do we need to keep this comment?
There was a problem hiding this comment.
Yes (it's a reminder). I will change it later, when I will finish the next part of CI updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSE https://linear.app/sourcegraph/issue/CODY-2816/ci-for-visual-studio-integration-tests-based-on-vsixtesting
UI Tests infrastructure (
Cody.VisualStudio.Tests) updated to allow running them, not only locally which were running fine from the very beginning, but also using GitHub Actions.Fixed threading issues only seen in GitHub Actions:
Call was Rejected By Callee(more about it), caused PlaywrightTestsBase.InitializeAsync() was called multiple times, which internally tries to call VS API, when XUnit was creating instances of all involved test classes